-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V5.1.0 #976
Open
ArthurSonzogni
wants to merge
47
commits into
main
Choose a base branch
from
v5.1.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
V5.1.0 #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the symetrical of `vscroll_indicator`. Requested by @ibrahimnasson. Fixed:#752
This a proposed MR to fix #754. While building the scroll bar the pixels were completely reseted thus canceling any style previously applied to said pixels. This MR removes this resetting of the pixels and leaves only the drawing of the shape of the scroll bar.
This fixes: #773 Dragging the mouse with the left button pressed now avoids activating multiple checkboxes. Add support for detecting mouse press transition. Added: ```cpp // The previous mouse event. Mouse Mouse::previous; // Return whether the mouse transitionned from: // released to pressed => IsPressed() // pressed to pressed => IsHeld() // pressed to released => IsReleased() bool Mouse::IsPressed(Button button) const; bool Mouse::IsHeld(Button button) const; bool Mouse::IsReleased(Button button) const; ``` A couple of components are now activated when the mouse is pressed, as opposed to released. Co-authored-by: ArthurSonzogni <[email protected]>
This should solve #766 The original PR was: #767 Co-authored-by: rbrugo <[email protected]> Co-authored-by: ArthurSonzogni <[email protected]>
It was intended to open gthe alternate screen.
This solve the issue encountered when using clang under MSVC.
Some users might destroy `this`, which would result in UAF. In the future, we should consider alternatives like posting a task to the main loop, or rely on users for this. Fixed:#804
Fixed: #812
It was introduced mistakenly by: f495ce0
…n drawing. (#831) When moving the cursor back to its original location, a problem arises when cursor placed in the right edge column, where an off by one error occur. This pull request will resolve this problem. Co-authored-by: Jørn Gustav Larsen <[email protected]> Co-authored-by: Jørn Gustav Larsen <[email protected]> Co-authored-by: ArthurSonzogni <[email protected]>
Co-authored-by: ArthurSonzogni <[email protected]>
Co-authored-by: ArthurSonzogni <[email protected]>
Co-authored-by: ArthurSonzogni <[email protected]>
This avoids an ordering problem with whatever the user printed and interacting with termios/WinAPI. Bug:#846
This is a no-op patch, but prefered, because this centralize the exit path below `Exit()`.
In order for applications to receive all keyboard inputs, including the Ctrl-C and Ctrl-Z, the raw input mode has been enabled. As result the SIGINT will no longer be used, instead the keyboard Ctrl-C event is used for exiting the framework, but only if no components has made use of it. Co-authored-by: Jørn Gustav Larsen <[email protected]> Co-authored-by: ArthurSonzogni <[email protected]>
Fix all the diagnostics reported. Bug: #828
fix typo
fix typo
correct spelling
There was a problem when v==0
Added -fPIC compile option.
To avoid burdening the user with explicit type construction when using the library, we can use a constructor that accepts an initializer list (std::initializer_list). This allows users to pass initializer lists directly without having to wrap them in std::vector<std::vector<std::string>>. This resolves the ambiguous case when the inner list contains only two elements. Bug:#912
Add SliderOption::on_change. Useful to observe a change to the value. Signed-off-by: Mikołaj Lubiak <[email protected]> Co-authored-by: ArthurSonzogni <[email protected]>
…950) For long tables (and other DOM elements), one may want the screen to render on dimensions higher than the terminal. Hence, this PR proposes a way to do so, with an optional parameter in the `Dimension::Fit` util function. Discussions / Issues : - #572 - #949 Bug:#572 Fixed:Bug:#572 Co-authored-by: ArthurSonzogni <[email protected]>
Fixed minor issue in function name
…reen not in use (#952)
ArthurSonzogni
force-pushed
the
v5.1.0
branch
from
December 26, 2024 17:50
3ec2337
to
634870f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.