Use actions/cache@v4 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks for your contribution, @svantreeck! |
ebronson68
approved these changes
Nov 14, 2024
|
Thanks for getting this in already! Saw a positive improvement where beforehand the upload was taking nearly 10m when it needed to upload and now its down to 40s with the same config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have been seeing slow cache saves, and actions/cache#1442 gives the impression that switching to the cache v4 action will potentially resolve it. actions/setup-node#878 makes it seem like using node 20 may be the cause, but prior to utilizing this action for caching our yarn installs, we didn't see multi-minute hangs on uploading artifacts, so hoping that cache@v4 will resolve it
Related Links