Fix/ Pinned Tokens Not Passed to Portfolio lib on failed RPC #1130
Conversation
…ned-tokens-not-passed-on-failed-rpc
…ned-tokens-not-passed-on-failed-rpc
| const getAccountNetworksWithAssets = ( | ||
| accountId: AccountId, | ||
| accountState: AccountState, | ||
| storageStateByAccount: { | ||
| [accountId: string]: NetworkId[] | ||
| [accountId: string]: { [networkId: NetworkId]: boolean } | NetworkId[] |
There was a problem hiding this comment.
Should we make { [networkId: NetworkId]: boolean } a type?
| if (nonZeroTokens.length || hasCollectibles) { | ||
| if (networksWithAssets.includes(networkId)) return | ||
|
|
||
| networksWithAssets.push(networkId) | ||
| return | ||
| networksWithAssets[networkId] = true | ||
| } else { | ||
| networksWithAssets[networkId] = false |
There was a problem hiding this comment.
networksWithAssets[networkId] = !!nonZeroTokens.length || hasCollectibles
| if (hasAssetsOnNetwork(storageStateByAccount[accountId], networkId)) { | ||
| networksWithAssets[networkId] = true | ||
| } else { | ||
| networksWithAssets[networkId] = false | ||
| } |
There was a problem hiding this comment.
If the RPC is down we shouldn't update the old value. To accomplish this we should initialize networksWithAssets with the old value:
const networksWithAssets: { [networkId: NetworkId]: boolean } = storageStateByAccount[accountId]
Then, in case of an RPC error we should simply return
if (!result || isRPCDown) return
because the result is not valid and thus the old value shouldn't be updated
There was a problem hiding this comment.
Also, please check if storageStateByAccount[accountId] matches the new structure. Imo if the value doesn't match the new structure we can discard it as it takes one update to switch to the new structure.
Closes 3294
Update the structure of networksWithAssetsByAccounts with an object structure and boolean for each network.
Display rpc еrror banner on 1. network is with asset 2. network is not yet added in the networksWithAssetsByAccounts