From ef21a9a8b19ad1ac18d509428dd2872b9a3020e6 Mon Sep 17 00:00:00 2001
From: Gabriel Destremont <gabriel.destremont@gmail.com>
Date: Thu, 31 Oct 2024 15:58:26 +0100
Subject: [PATCH] echart: enable svg rendering

---
 nicegui/elements/echart.js | 8 +++++++-
 nicegui/elements/echart.py | 4 +++-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/nicegui/elements/echart.js b/nicegui/elements/echart.js
index 3a5e33a66..3b58705fc 100644
--- a/nicegui/elements/echart.js
+++ b/nicegui/elements/echart.js
@@ -9,7 +9,12 @@ export default {
       await import("echarts-gl");
     }
 
-    this.chart = echarts.init(this.$el);
+    if (this.enable_svg) {
+      this.chart = echarts.init(this.$el, null, {renderer: 'svg'});
+    } else {
+      this.chart = echarts.init(this.$el);
+    }
+    
     this.chart.on("click", (e) => this.$emit("pointClick", e));
     for (const event of [
       "click",
@@ -90,5 +95,6 @@ export default {
   props: {
     options: Object,
     enable_3d: Boolean,
+    enable_svg: Boolean
   },
 };
diff --git a/nicegui/elements/echart.py b/nicegui/elements/echart.py
index 5c5f45ceb..2e6dbcdbc 100644
--- a/nicegui/elements/echart.py
+++ b/nicegui/elements/echart.py
@@ -22,7 +22,7 @@ class EChart(Element,
              dependencies=['lib/echarts/echarts.min.js', 'lib/echarts-gl/echarts-gl.min.js'],
              default_classes='nicegui-echart'):
 
-    def __init__(self, options: Dict, on_point_click: Optional[Handler[EChartPointClickEventArguments]] = None, *, enable_3d: bool = False) -> None:
+    def __init__(self, options: Dict, on_point_click: Optional[Handler[EChartPointClickEventArguments]] = None, *, enable_3d: bool = False, enable_svg: bool = False) -> None:
         """Apache EChart
 
         An element to create a chart using `ECharts <https://echarts.apache.org/>`_.
@@ -32,10 +32,12 @@ def __init__(self, options: Dict, on_point_click: Optional[Handler[EChartPointCl
         :param options: dictionary of EChart options
         :param on_click_point: callback that is invoked when a point is clicked
         :param enable_3d: enforce importing the echarts-gl library
+        :param enable_svg: enable svg rendering for this chart
         """
         super().__init__()
         self._props['options'] = options
         self._props['enable_3d'] = enable_3d or any('3D' in key for key in options)
+        self._props['enable_svg'] = enable_svg
 
         if on_point_click:
             self.on_point_click(on_point_click)