Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak with Node 22 and 23 #7

Open
UlisesGascon opened this issue Jan 18, 2025 · 0 comments
Open

Memory leak with Node 22 and 23 #7

UlisesGascon opened this issue Jan 18, 2025 · 0 comments

Comments

@UlisesGascon
Copy link
Member

Seems like there is an error while running the tests in Node@22 and Node@23 for all the platforms.

I was able to reproduce it locally using Ubuntu (Intel) and [email protected]

Ubuntu

Run npm test

> [email protected] test

  #  node[1888]: void node::fs::InternalModuleStat(const v8::FunctionCallbackInfo<v8::Value>&) at ../src/node_file.cc:1037
  #  Assertion failed: (args.Length()) >= (2)

> ava

----- Native stack trace -----

 1: 0xf76da7 node::Assert(node::AssertionInfo const&) [node]
 2: 0xf7e397  [node]
 3: 0x7f06e860f5e2 

----- JavaScript stack trace -----

1: /home/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:34535
2: /home/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:34176
3: /home/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:34506
4: /home/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:173374
5: /home/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:173420
6: /home/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:173521
7: /home/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:258942
8: /home/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:261569
9: e (/home/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:262673)
10: get (/home/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:262740)


Aborted (core dumped)
Error: Process completed with exit code 134.

MacOS

Run npm test

> [email protected] test
> ava


  #  node[3837]: void node::fs::InternalModuleStat(const FunctionCallbackInfo<v8::Value> &) at ../src/node_file.cc:1039
  #  Assertion failed: (args.Length()) >= (2)

----- Native stack trace -----

 1: 0x104898d1c node::Assert(node::AssertionInfo const&) [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
 2: 0x1064c63a4 node::fs::InternalModuleStat(v8::FunctionCallbackInfo<v8::Value> const&) (.cold.3) [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
 3: 0x1048acc94 node::fs::InternalModuleStat(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
 4: 0x105476f98 Builtins_CallApiCallbackGeneric [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
 5: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
 6: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
 7: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
 8: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
 9: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
10: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
11: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
12: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
13: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
14: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
15: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
16: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
17: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
18: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
19: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
20: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
21: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
22: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
23: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
24: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
25: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
26: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
27: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
28: 0x105474ef0 Builtins_InterpreterEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
29: 0x105472c0c Builtins_JSEntryTrampoline [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
30: 0x1054728f4 Builtins_JSEntry [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
31: 0x104c0a728 v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
32: 0x104c0a06c v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
33: 0x104adae8c v8::Function::Call(v8::Local<v8::Context>, v8::Local<v8::Value>, int, v8::Local<v8::Value>*) [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
34: 0x10487533c node::builtins::BuiltinLoader::CompileAndCall(v8::Local<v8::Context>, char const*, node::Realm*) [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
35: 0x10492034c node::Realm::ExecuteBootstrapper(char const*) [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
36: 0x104853810 node::StartExecution(node::Environment*, char const*) [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
37: 0x10485372c node::StartExecution(node::Environment*, std::__1::function<v8::MaybeLocal<v8::Value> (node::StartExecutionCallbackInfo const&)>) [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
38: 0x1047ba460 node::LoadEnvironment(node::Environment*, std::__1::function<v8::MaybeLocal<v8::Value> (node::StartExecutionCallbackInfo const&)>, std::__1::function<void (node::Environment*, v8::Local<v8::Value>, v8::Local<v8::Value>)>) [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
39: 0x1048e05cc node::NodeMainInstance::Run(node::ExitCode*, node::Environment*) [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
40: 0x1048e03c4 node::NodeMainInstance::Run() [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
41: 0x104856f88 node::Start(int, char**) [/Users/runner/hostedtoolcache/node/22.13.0/arm64/bin/node]
42: 0x1817db154 start [/usr/lib/dyld]

----- JavaScript stack trace -----

1: /Users/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:34535
2: /Users/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:34176
3: /Users/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:34506
4: /Users/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:173374
5: /Users/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:173420
6: /Users/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:173521
7: /Users/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:258942
8: /Users/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:261569
9: e (/Users/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:262673)
10: get (/Users/runner/work/yeoman-welcome/yeoman-welcome/node_modules/esm/esm.js:1:262740)


/Users/runner/work/_temp/847dda9f-8fb3-410d-acc3-35d8e7a38b0a.sh: line 1:  3812 Abort trap: 6           npm test
Error: Process completed with exit code 134.

Windows


Run npm test

> [email protected] test
> ava


  #  Administrator:  C:\Windows\system32\cmd.exe [3340]: void __cdecl node::fs::InternalModuleStat(const class v8::FunctionCallbackInfo<class v8::Value> &) at c:\ws\src\node_file.cc:1039
  #  Assertion failed: (args.Length()) >= (2)

----- Native stack trace -----

 1: 00007FF69ED0093D node::SetCppgcReference+17261
 2: 00007FF69EC66E61 v8::base::CPU::num_virtual_address_bits+84273
 3: 00007FF69EC52F38 v8::base::CPU::num_virtual_address_bits+2568
 4: 00007FF63F7CFA64 

----- JavaScript stack trace -----

1: D:\a\yeoman-welcome\yeoman-welcome\node_modules\esm\esm.js:1:34535
2: D:\a\yeoman-welcome\yeoman-welcome\node_modules\esm\esm.js:1:34176
3: D:\a\yeoman-welcome\yeoman-welcome\node_modules\esm\esm.js:1:34506
4: D:\a\yeoman-welcome\yeoman-welcome\node_modules\esm\esm.js:1:173374
5: D:\a\yeoman-welcome\yeoman-welcome\node_modules\esm\esm.js:1:173420
6: D:\a\yeoman-welcome\yeoman-welcome\node_modules\esm\esm.js:1:173521
7: D:\a\yeoman-welcome\yeoman-welcome\node_modules\esm\esm.js:1:258942
8: D:\a\yeoman-welcome\yeoman-welcome\node_modules\esm\esm.js:1:261569
9: e (D:\a\yeoman-welcome\yeoman-welcome\node_modules\esm\esm.js:1:262673)
10: get (D:\a\yeoman-welcome\yeoman-welcome\node_modules\esm\esm.js:1:262740)
@UlisesGascon UlisesGascon mentioned this issue Jan 18, 2025
UlisesGascon added a commit that referenced this issue Jan 18, 2025
Migration from Travis to GitHub Actions (b85a521), also engine versions are now updated with a known limitation for Node@22 and Node@23 ([see](#7)). Also replace build sticker in the `README.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant