-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adguard clarification #169
Comments
Hi, thanks for this clarification, this seems like a reasonable explanation. We do detect all third-party calls from the page, so these injected ones will also appear in the data. The fingerprinting signal could be triggered if you are injecting a persistent identifier with your script, which our system is detecting as unique to individual users. I think a simple fix for these cases will be to check the IP third-party requests are served on, and exclude ones served from localhost addresses. |
Yeah, and I guess "Cookies" is triggered by using a subdomain of
Well, it's trickier than that. Localhost cannot be used as it won't work for https websites. There are two real IP addresses ( Smth like this:
|
In that case it is not possible from the perspective of where we measure to verify that this request is not sent externally. I suggest we leave this issue open as a reference, but leave the tracker listing on the site as-is. |
Well, it still bothers me that AG is categorized as a tracker while we do exactly the opposite. I suppose this is a mistake that can be corrected. If your only concern is verification, you can easily verify my words by yourself. How to verify it by yourself:
If this is not enough, we can arrange a demonstration (skype/zoom/whatever) and I'll answer any questions you might have, and even show parts of the code responsible for this logic so that you had no doubts. |
I was able to verify that the current version of the AdGuard application behaves as you describe, however I am still unsure that removing the entry is the correct response: WhoTracks.Me is a transparency tool - it shows which entities are tracking them, and who have the potential to track them. One example of this distinction is Google Fonts. Google fonts do not track users loading them, however we still display them on the WhoTracks.Me website. Why? They have a significant reach, and because of this they could switch to tracking users overnight simply by starting to set cookies for font requests. As Adguard injects itself as a Man-in-the-middle on all pages loaded, WhoTracks.Me also considers AdGuard has having a potential to track. As Perhaps I am missing some technical issues, but I believe you could point this local hostname at |
Hi Sam, I have nothing against listing AdGuard on WhoTracks.me. There is nothing wrong with showing people that
Just for the sake of argument, this is also true for any browser extension including Ghostery:)
It's been years since we opted to use this approach. At that time there were some browsers bugs that prevented us from simply using localhost. We'll re-evaluate this option, but anyway, there are some use cases when using a domain name is necessary. For instance, you can run AdGuard for Mac in proxy mode and configure your home devices to use it as a proxy server (thus you'll be able to manage content blocking centrally). edit: just pointing the domain name won't work, browsers don't like domains pointing to localhost, so we'll need to actually use |
Regarding the statements:
|
Sam, this would be great, thank you! Also, please don't get me wrong - I am not pushing for any immediate changes or whatever. I often use WhoTracks.me myself to find out what company is behind this or that tracker, and you're doing a fantastic job. But I believe this is in your best interest to have accurate data. |
"...and [which entities] have the potential to track them" That's a fairly vague definition that essentially includes every entity. |
I feel like the inclusion of "any potential tracking tool" reduces the efficacy of such a database to near zero, especially if these false positives are not clearly marked or are easily conflated. While I don't think manual review of every single record in your dataset is reasonable to expect, when a false positive like adguard is identified (which decreases this "potential" for tracking), it should probably be removed... |
Hi!
I've just found out that Adguard is listed as a tracker on whotracksme: https://whotracks.me/trackers/adguard.html
This is not quite true, but I can see where it comes from. Let me please clarify the situation.
<script src="https://local.adguard.com/blahblah/content-script.js">
that takes care of cosmetic rules.local.adguard.com
are intercepted by the network driver and processed locally. Also, we changed the domain tolocal.adguard.org
in the newer versions.What's important here:
The text was updated successfully, but these errors were encountered: