Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider actually checking for the existence of the given GitHub IDs #8

Open
domenic opened this issue Dec 18, 2017 · 3 comments
Open

Consider actually checking for the existence of the given GitHub IDs #8

domenic opened this issue Dec 18, 2017 · 3 comments

Comments

@domenic
Copy link
Member

domenic commented Dec 18, 2017

After #7, GitHub IDs are getting some validation. But we could go further and probe the GitHub API to ensure they actually exist as well. This removes some work from those doing the later validation.
@domenic
Copy link
Member Author

domenic commented Aug 21, 2018

whatwg/participant-data#7 would have been prevented by this.

@domenic domenic mentioned this issue Oct 8, 2018
Closed
@annevk
Copy link
Member

annevk commented Oct 29, 2018

whatwg/participant-data@27c67c2 also seems fake.

@domenic
Copy link
Member Author

domenic commented Mar 12, 2019

Worth mentioning that we could also have people log in with GitHub OAuth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @annevk