Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data curation: invalid IDL may trigger "Maximum call stack size exceeded" error #595

Open
tidoust opened this issue May 10, 2022 · 1 comment

Comments

@tidoust
Copy link
Member

tidoust commented May 10, 2022

Data curation job currently fails with a "Maximum call stack size exceeded" error during generation of IDL names, see for instance https://github.com/w3c/webref/runs/6364928486

Re-generate the idlnames and idlnamesparsed folders
[warn] IDL Names - No definition found WebGLContextAttributes
[warn] IDL Names - No definition found WebGLRenderingContextBase
RangeError: Maximum call stack size exceeded
    at /home/runner/work/webref/webref/node_modules/reffy/src/cli/generate-idlnames.js:281:22
    at Set.forEach (<anonymous>)
    at /home/runner/work/webref/webref/node_modules/reffy/src/cli/generate-idlnames.js:281:14
    at Array.forEach (<anonymous>)
    at addDfns (/home/runner/work/webref/webref/node_modules/reffy/src/cli/generate-idlnames.js:277:34)
    at /home/runner/work/webref/webref/node_modules/reffy/src/cli/generate-idlnames.js:285:39
    at Array.forEach (<anonymous>)
    at addDfns (/home/runner/work/webref/webref/node_modules/reffy/src/cli/generate-idlnames.js:285:23)
    at /home/runner/work/webref/webref/node_modules/reffy/src/cli/generate-idlnames.js:285:39
    at Array.forEach (<anonymous>)
npm ERR! code 1
npm ERR! path /home/runner/work/webref/webref
npm ERR! command failed
npm ERR! command sh -c node tools/prepare-curated.js ed curated && node tools/prepare-packages.js curated packages
@tidoust tidoust added the bug label May 10, 2022
@tidoust tidoust transferred this issue from w3c/browser-specs May 10, 2022
@tidoust
Copy link
Member Author

tidoust commented May 10, 2022

Actually triggered by invalid IDL in the WebGL1 spec introduced 3 days ago, see KhronosGroup/WebGL#3407. It would be good to catch that invalid IDL error before attempting to generate IDL names, especially if the net result is an endless loop that seems totally unrelated... Adjusting the bug title accordingly.

@tidoust tidoust changed the title Data curation: "Maximum call stack size exceeded" error Data curation: invalid IDL may trigger "Maximum call stack size exceeded" error May 10, 2022
@tidoust tidoust removed the bug label Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant