-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify semantics of CSS extracts #1289
Comments
I'm still not clear about what a "CSS value" is, and how it is to be scoped. In this particular example: Similarly, with that logic, what should
Isn't the fact that these two names cannot be defined in one spec with appropriate definition types evidence that the names are, so far at least, meant to be in the same namespace? If you combine the two definitions in one spec, Bikeshed will report a You could elect to use Anyway, I would focus more initially on finding ways to surface the distinction in the specs rather than in our extracts. I'm at step zero today: I don't see a clear distinction, and I don't know how to surface it ;) |
It emerges in #1288 that the ambiguity that exists in the CSS-related
dfn-type
of the DFN contract has sipped into our model of CSS extracts.In particular, #1288 stems for our tests currently flagging
<combinator>
in css-mixins-1 as duplicate of<combinator>
in selectors-4, whereas the two names are not in the same namespace: the latter is used to parse a selector, the former to parse a CSS value, but both appears under avalues
list with atype: type
.Unless we find spec-evidence that the two names are in fact meant to be in the same namespace (and thus the test failure would be a sign of a spec bug), we need to not fail in such a situation, which I think entails surfacing that namespacing one way or another.
My personal interpretation of
values
in our CSS extracts was to match https://drafts.csswg.org/css-values-4/#value-defs , in which case<combinator>
should not appear under such a list in selectors.json, and we would need either to find a way to ignore these constructs in reffy, or (probably preferably) find a way to surface them in a different structure.The text was updated successfully, but these errors were encountered: