Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with blockquotes' pseudo-element styles #4134

Open
kfranqueiro opened this issue Nov 4, 2024 · 3 comments
Open

Problems with blockquotes' pseudo-element styles #4134

kfranqueiro opened this issue Nov 4, 2024 · 3 comments

Comments

@kfranqueiro
Copy link
Contributor

kfranqueiro commented Nov 4, 2024

Blockquotes in the Understanding docs include styling which adds an open quote on blockquote p:first-of-type::before, and a close quote on blockquote p:last-of-type::after. Unfortunately, this causes problems in many situations that involve multiple paragraphs, which often involves nesting.

Examples captured by @mbgower:

image

image

image

@patrickhlauke
Copy link
Member

patrickhlauke commented Nov 5, 2024

I'd suggest just removing/overriding that styling? it seems well-meaning but overly naive

@bruce-usab
Copy link
Contributor

bruce-usab commented Nov 6, 2024

Are there pages where this styling is seemingly working as intended?

I have a hard time coming up with a situation where this formatting would be of any practical utility, at least not with our docs. I think there is a convention in print where a several-paragraphs-long quotation begins each paragraph in the set with “ but only the last paragraph (in the set) ends with ”

@kfranqueiro
Copy link
Contributor Author

I think the only cases where it works fully as would be expected are under First Exception and Second Exception in Focus Appearance - which each consist of only a single paragraph and nothing else. If we wanted to only apply this behavior to those, I imagine we could use :only-child, but at that point is it even worth having at all for 2 cases out of over a dozen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants