Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Don't hardcode remote name #1286

Open
tidoust opened this issue Mar 26, 2024 · 0 comments
Open

[CLI] Don't hardcode remote name #1286

tidoust opened this issue Mar 26, 2024 · 0 comments

Comments

@tidoust
Copy link
Member

tidoust commented Mar 26, 2024

When the --pr option is set, the CLI command needs to push committed changes to GitHub before it can create a pull request. The code currently assumes that the name of the remote to use is origin. That may not be the case, especially if the code is forked (or if someone who's like me does not like the name origin and decides to rename it). The code should rather look at possible remotes and choose the right one (essentially, the one that targets w3c/browser-specs on GitHub).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant