Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute-shortname: should always get a URL as parameter #1219

Open
tidoust opened this issue Feb 19, 2024 · 0 comments
Open

compute-shortname: should always get a URL as parameter #1219

tidoust opened this issue Feb 19, 2024 · 0 comments

Comments

@tidoust
Copy link
Member

tidoust commented Feb 19, 2024

Via bb940c2

The exported function from src/compute-shortname.js takes a URL or a shortname. On top of making the code slightly confusing, it makes it impossible to base logic on the URL itself, since it may not be what the function gets. Function should rather updated to take a URL and a possible shortname.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tidoust