Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping of patches during extension #233

Open
skef opened this issue Nov 8, 2024 · 2 comments
Open

Grouping of patches during extension #233

skef opened this issue Nov 8, 2024 · 2 comments
Assignees

Comments

@skef
Copy link
Contributor

skef commented Nov 8, 2024

Related to #232

The extension algorithm says:

For each of tables 'IFT ' and 'IFTX' (if present): convert the table into a list of entries by invoking Interpret Format 1 Patch Map or Interpret Format 2 Patch Map. Concatenate the returned entry lists into a single list, entry list.

And then later:

Pick one entry from entry list with the following procedure:

  • If entry list contains one or more patch map entries which have a patch format that is Full Invalidation then, select exactly one of the Full Invalidation entries in entry list. The criteria for selecting the single entry is left up to the implementation to decide.
  • Otherwise if entry list contains one or more patch map entries which have a patch format that is Partial Invalidation then, select exactly one of the Partial Invalidation entries in entry list. The criteria for selecting the single entry is left up to the implementation to decide.
  • Otherwise select exactly one of the No Invalidation entries in entry list. The criteria for selecting the single entry is left up to the implementation to decide.

Why aren't we instructing people to make (up to 3) lists grouped by patch encoding, and then process those lists in the specified order? You'd never want to put them in a single list in practice and I don't see what the generality is buying us here.

@skef
Copy link
Contributor Author

skef commented Nov 8, 2024

If the concern is about future patch formats that might share invalidation categories, I'm happy to have the lists grouped by invalidation category rather than format.

@garretrieger garretrieger self-assigned this Nov 9, 2024
@garretrieger
Copy link
Contributor

garretrieger commented Nov 9, 2024

There's no particular reason for them to be merged into a single list, it should be functionally equivalent to have the text say to separate them into one list per invalidation type. I can update the text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants