Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every pg will record a Unschedulable type event fisrt no matter whether resources are enough and then schedule successfully. #3749

Open
liuyuanchun11 opened this issue Sep 26, 2024 · 4 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@liuyuanchun11
Copy link
Contributor

Description

  1. duplicated condition update with Unschedulable and Scheduled, just retain one Scheduled is enough.
  2. and add an extended condition to express the Unenqueueable event.
  3. every pg will record a Unschedulable type event fisrt no matter whether resources are enough and then schedule successfully.

Steps to reproduce the issue

  1. Create a vcjob in a cluster with sufficient resources. The vcjob is scheduled normally and is in the running state.
  2. Execute "kubectl describe pg xxx", will see podgroup contains conditions that unschedulable and scheduled.
    3.Execute “kubectl get events --sort-by='.metadata.creationTimestamp'”, will see warning event "job xxx unscheduler, reasion:...."

Describe the results you received and expected

expected:

  1. Only one condition is used to describe podgroup scheduling.
  2. No unscheduable warning event occurs in the pod group that is normally scheduled.

What version of Volcano are you using?

v1.9.0

Any other relevant information

No response

@liuyuanchun11 liuyuanchun11 added the kind/bug Categorizes issue or PR as related to a bug. label Sep 26, 2024
@JesseStutler
Copy link
Member

I think it's a good issue. /cc @Monokaix

@JesseStutler
Copy link
Member

/assign

@lowang-bh
Copy link
Member

as for point 2, there is already an PR #3045.

@Monokaix
Copy link
Member

Monokaix commented Oct 8, 2024

as for point 2, there is already an PR #3045.

Maybe we can add a new condition type named Unenqueueable instead of a reason attached to Unschedulable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants