Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-defined environment vars should be loaded after ones defined in this module #43

Open
dmattia opened this issue Feb 29, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@dmattia
Copy link

dmattia commented Feb 29, 2024

Right now, there is no way to override environment variables this module sets.

This is especially problematic given that ENCRYPTION_KEY is always the random string: https://github.com/tryretool/terraform-retool-modules/blob/main/modules/aws_ecs/locals.tf#L42-L45

I would like a way to customize the ENCRYPTION_KEY, but this does not seem possible with this module right now

@samsternatretool
Copy link
Contributor

@dmattia thanks for the feedback! Two questions:

  1. Can you elaborate a bit more on why you need to customize the encryption key? I want to make sure I understand your use case.
  2. Would you be willing to submit a PR implementing this change?

@samsternatretool samsternatretool added the enhancement New feature or request label Mar 1, 2024
@lynnwellhausen
Copy link

@samsternatretool here is the ticket that documents our discovery of the issue. I think that will be helpful for giving you greater context.

@samsternatretool
Copy link
Contributor

@lynnwellhausen thanks for providing that intercom link, that gives me a lot more background. I'm not personally familiar with this behavior but it does seem wrong to me, I'll ask around the team.

In the meantime if you or anyone on your end wants to send a PR with a proposed fix (even if it's just a partial fix that you'd like us to complete), I'd be happy to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants