Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Deprecate QueryErrorBoundary? #1325

Open
manudeli opened this issue Oct 18, 2024 · 3 comments
Open

[Feature]: Deprecate QueryErrorBoundary? #1325

manudeli opened this issue Oct 18, 2024 · 3 comments
Assignees
Milestone

Comments

@manudeli
Copy link
Member

manudeli commented Oct 18, 2024

Package Scope

@suspensive/react-query

Description

// optional-peer-dep:__vite-optional-peer-dep:@suspensive/react:@suspensive/react-query-4
throw new Error(`Could not resolve "@suspensive/react" imported by "@suspensive/react-query-4". Is it installed?`);

Due to the peerDep issue of @suspensive/react-query, some projects have the problem of having to install @suspensive/react. The implementation of QueryErrorBoundary is simple and leaving this implementation up to the user seems to end these problems and solve the peerDep problem.

@gwansikk I want to talk about this issue

Possible Solution

No response

etc.

No response

Copy link

coauthors bot commented Oct 18, 2024

People can be co-author:

Candidate Reasons Count Add this as commit message
@manudeli #1325 (comment) #1325 2 Co-authored-by: manudeli <[email protected]>
@gwansikk #1325 (comment) 1 Co-authored-by: gwansikk <[email protected]>

@gwansikk
Copy link
Collaborator

gwansikk commented Oct 18, 2024

The implementation of QueryErrorBoundary is simple and leaving this implementation up to the user seems to end these problems and solve the peerDep problem.

I agree. A QueryErrorBoundary can be easily created by the user, and I believe it should be up to the user’s discretion as needed.

How about deprecating it and simply providing guidance in the form of a recipe? For example, a guide explaining how users can combine @suspensive/react-query with @suspensive/react. (This is just a suggestion.)

like Jotai RECIPES: https://jotai.org/docs/recipes/large-objects

@manudeli manudeli added this to the v3 milestone Oct 19, 2024
@manudeli
Copy link
Member Author

Let's do this in v3

manudeli added a commit that referenced this issue Nov 14, 2024
manudeli added a commit that referenced this issue Nov 14, 2024
related #1325

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants