Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Containers with Reuse should not be killed by Ryuk #2654

Open
mdelapenya opened this issue Jul 17, 2024 · 2 comments · May be fixed by #2768
Open

[Feature]: Containers with Reuse should not be killed by Ryuk #2654

mdelapenya opened this issue Jul 17, 2024 · 2 comments · May be fixed by #2768
Labels
feature New functionality or new behaviors on the existing one

Comments

@mdelapenya
Copy link
Member

mdelapenya commented Jul 17, 2024

Problem

When using Reuse containers, and Ryuk is enabled, the containers will be terminated by Ryuk after the test session.

Solution

If the Reuse containers are not connecting to Ryuk, it will not kill them afterwards

Benefit

Reuse mode will work more consistently across different test sessions, allowing users to create a better dev experience

Would you like to help contributing this feature?

Yes

@mdelapenya mdelapenya added the feature New functionality or new behaviors on the existing one label Jul 17, 2024
@stevenh
Copy link
Collaborator

stevenh commented Aug 8, 2024

This should be easy to add with the reaper changes in #2664

@mdelapenya mdelapenya linked a pull request Sep 4, 2024 that will close this issue
@mdelapenya
Copy link
Member Author

I think #2768 will solve this. Would appreciate your review 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or new behaviors on the existing one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants