Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have useful selinux status output in provision data #3364

Open
KwisatzHaderach opened this issue Nov 15, 2024 · 1 comment
Open

Have useful selinux status output in provision data #3364

KwisatzHaderach opened this issue Nov 15, 2024 · 1 comment
Labels
security Security related issues and changes step | provision Stuff related to the provision step

Comments

@KwisatzHaderach
Copy link
Collaborator

For now have selinux: yes which is taken from /proc/filesystems, this seems like a weird choice since even on my system with selinux disabled this file contains the string selinux causing tmt provision to think my system has selinux enabled (or yes, whatever that is supposed to mean :) ).

It would be great if there would be an actual state and mode, so we know if selinux is permissive or enforcing.

@KwisatzHaderach KwisatzHaderach added step | provision Stuff related to the provision step security Security related issues and changes labels Nov 15, 2024
@happz
Copy link
Collaborator

happz commented Nov 15, 2024

For now have selinux: yes which is taken from /proc/filesystems, this seems like a weird choice since even on my system with selinux disabled this file contains the string selinux causing tmt provision to think my system has selinux enabled (or yes, whatever that is supposed to mean :) ).

In this context, selinux: yes means SELinux is enabled. Running restorecon will not explode. This is true even if it's (temporarily...) set to permissive mode.

It would be great if there would be an actual state and mode, so we know if selinux is permissive or enforcing.

For tmt this particular information was not important, as long as SELinux is enabled, tmt tries to behave nicely as if the user would switch to enforcing mode at any moment. I think it can be added, but IMO it fits the category of "system report", together with many other bits like "currently installed packages", "available repositories" or "HW configuration". Maybe we could have a plugin to gather this info in general, at one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Security related issues and changes step | provision Stuff related to the provision step
Projects
None yet
Development

No branches or pull requests

2 participants