Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace jsonschema.RefResolver as is being deprecated #194

Open
martinhoyer opened this issue Jul 21, 2023 · 2 comments
Open

Replace jsonschema.RefResolver as is being deprecated #194

martinhoyer opened this issue Jul 21, 2023 · 2 comments

Comments

@martinhoyer
Copy link
Contributor

Copy-pasting the deprecation warning:

fmf/base.py:682: DeprecationWarning: jsonschema.RefResolver is deprecated as of v4.18.0, in favor of the https://github.com/python-jsonschema/referencing library, which provides more compliant referencing behavior as well as more flexible APIs for customization. A future release will remove RefResolver. Please file a feature request (on referencing) if you are missing an API for the kind of customization you need.

4.18.0 was released July 6th.

If there is no-one available to work on this now, perhaps a max version lock in installrequires like jsonschema<4.18 would be a adequate temporary solution.

@lukaszachy
Copy link
Collaborator

Hm, while locking version will work for PyPI we can't do that in fedora-rawhide which might get 4.18 at some point.

@martinhoyer
Copy link
Contributor Author

Hm, while locking version will work for PyPI we can't do that in fedora-rawhide which might get 4.18 at some point.

Indeed, see bz#2223179)

Locking the version now would ensure parity between rpms and pypi, but is not crucial I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants