Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Preview mode for drafts, allow inline comments on previews #18

Open
techwraith opened this issue Jun 10, 2013 · 2 comments
Open
Milestone

Comments

@techwraith
Copy link
Owner

No description provided.

@ben-ng
Copy link
Collaborator

ben-ng commented Aug 5, 2013

+1 for this, i actually have a post i would like to do this with right now.

how would inline comments on previews work? once the original post gets edited the comment positions will go out of sync.

@techwraith
Copy link
Owner Author

I think we'll need to introduce the concept of post versions at this point. The cool thing there though is we get version control as a side effect.

Basically, people can comment on a version, but they can't comment on a specific line. The UX will need a lot of work to get this to feel right.

I was thinking that you'd send a link out to people with a unique version ID, then they'd highlight a line, and once highlighted, a menu will show up. In that menu will be "add comment". After clicking "add comment" a form will show up on the left side of the article in line with the highlighted text. Once the comment is submitted, a link will be inserted in that version around the highlighted text, when that link is clicked, the comment will be shown on the left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants