Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forums] The Swift icon renders black text in dark mode. #590

Open
furby-tm opened this issue Mar 12, 2024 · 6 comments
Open

[forums] The Swift icon renders black text in dark mode. #590

furby-tm opened this issue Mar 12, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@furby-tm
Copy link

Describe the bug

First off, I love all the recent design changes with the site lately, I feel pretty stupid for writing a issue ticket for this tiny little visual bug but, 😅

The swift icon renders the incorrect color text in dark mode on the forums.

I'm sorry, 😭.

To Reproduce

Steps to reproduce the behavior:

  1. Put your OS in dark mode.
  2. Go to https://forums.swift.org.
  3. See top left swift icon.

Expected behavior

The swift icon should render the text that says "Swift" white against the black navbar when the OS is in dark mode on the forums, and the inverse for light mode.

Actual behavior

The swift icon renders the text that says "Swift" black against the black navbar when the OS is in dark mode on the forums, however light mode looks fine.

Screenshots

Screenshot 2024-03-11 at 11 14 48 PM Screenshot 2024-03-11 at 11 30 39 PM

Environment details

Desktop:

  • OS: macOS Sonoma 14.4
  • Browser: Safari
  • Version: 17.4
@furby-tm furby-tm added the bug Something isn't working label Mar 12, 2024
@0xTim
Copy link
Member

0xTim commented Mar 14, 2024

@shahmishal I'm guessing you're responsible for the forums?

@alexandersandberg
Copy link
Member

We chatted about this internally but will add it here as well: this can be done in the Discourse settings.

Assigning Mishal as well as he said he could take a look. 🙂

@dempseyatgithub
Copy link
Contributor

First off, I love all the recent design changes with the site lately, I feel pretty stupid for writing a issue ticket for this tiny little visual bug but, 😅

Your feedback is greatly appreciated @furby-tm. Thank you for taking the time report this!

@Hybried8
Copy link

Hybried8 commented Apr 2, 2024

Hi!

Sorry if this is a bother, but I was reviewing this issue and the swift logo is white on my white on my computer, is there something I'm missing?

@furby-tm
Copy link
Author

furby-tm commented Apr 3, 2024

Hi!

Sorry if this is a bother, but I was reviewing this issue and the swift logo is white on my white on my computer, is there something I'm missing?

Interesting @Hybried8! What browser and OS might you happen to be using in order to potentially help the collaborators better pinpoint this issue?

Note

Also I realize this may very well just be a bug with Discourse, and if so - feel free to close this out/I could perhaps link this issue to a new issue for that platform if your configuration settings linked above all check out okay, or if this is what appears may be an experimental feature not yet available on your hosted site.

@Hybried8
Copy link

Hybried8 commented Apr 3, 2024

Ok wait @furby-tm it's black again now, when I opened it on windows it was white but now it's black. Please don't close it I was wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants