Migrate plugin generated from swc plugin new
to use .cargo/config.toml
instead of .cargo/config
to fix warning
#9740
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As per https://doc.rust-lang.org/cargo/reference/config.html we should be generating a
.cargo/config.toml
instead of.cargo/config
when creating a new pluginMotivation - console warnings 😆
BREAKING CHANGE:
Technically this means users must have a toolchain > 1.38 (released september, 2019 - so five years ago).
Given that:
swc plugin new ..
swc-project/swc
MSRV is 1.73 anyways - whilst that doesn't specifically refer to generated code, it shows the intent of the project :)I don't believe it will have material impact.
I will raise a separate PR to generate the correct MSRV for both
swc-project/swc
and the generated plugin itself.Related issue (if exists):