Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly suppress sending non-fatals if we know the Throwable is for a network connection issue #22

Open
ssawchenko opened this issue Jul 20, 2020 · 2 comments
Open

Possibly suppress sending non-fatals if we know the Throwable is for a network connection issue #22

ssawchenko opened this issue Jul 20, 2020 · 2 comments
Labels
xp-steamclog-swift

Comments

@ssawchenko
Copy link
Collaborator

This happened on VB - we were reporting non-fatals when calls failed due to a network connection issue. In most cases, this is not a case where we'd want to mark a non-fatal (unless it produced a situation that would impact the user).

May want to check the Throwable before being logged, and only log if not an IOException
@ssawchenko ssawchenko self-assigned this Sep 3, 2020
@ssawchenko ssawchenko assigned ssawchenko and unassigned ssawchenko Sep 28, 2020
@ssawchenko ssawchenko assigned ssawchenko and unassigned ssawchenko Aug 16, 2021
ssawchenko added a commit that referenced this issue Aug 17, 2021
@ssawchenko
Added config.blockedThrowables to allow specific Throwables/Exception…
0c94594 
…s to be suppressed from being sent as an error to the crash reporting destination (#22)

* Updated sample app with way to test blocked exceptions
* Added small message to help the sample app tester know that crash reporting is not enabled in their current configuation
@ssawchenko ssawchenko mentioned this issue Aug 17, 2021
Merged
ssawchenko added a commit that referenced this issue Aug 31, 2021
@ssawchenko
Added ability to block specific Throwables from being logged as an er…
1074996 
…ror (#22)
@steamclock-bot steamclock-bot mentioned this issue Sep 2, 2021
Closed
@ssawchenko
Copy link
Collaborator Author

Keeping this open. Now that we have support for having a list of blocked throawbles, we may want to support a default set of known noisy throwables/exceptions and have them blocked by default.

@ssawchenko ssawchenko removed their assignment Aug 30, 2022
@ssawchenko
Copy link
Collaborator Author

Note, iOS changed the name from FilterOut to SentryFilter in 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
xp-steamclog-swift
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ssawchenko