-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Climate Setting Schedules #659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to block merge because this will be a breaking change / new major version, and I don't want this to merge early.
disableResourceIds, | ||
disableConnectedAccountInformation, | ||
disableClimateSettingSchedules, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should removed this from the API. Are there any other references to ClimateSettingSchedules in this project?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Removed all in 3457ca4
Co-authored-by: Evan Sosenko <[email protected]>
closes #658
Notable things