Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Climate Setting Schedules #659

Merged
merged 13 commits into from
Oct 21, 2024
Merged

Remove Climate Setting Schedules #659

merged 13 commits into from
Oct 21, 2024

Conversation

mikewuu
Copy link
Contributor

@mikewuu mikewuu commented Oct 8, 2024

closes #658

Notable things

  • Removes ability to change default climate settings as it's been deprecated.

@mikewuu mikewuu changed the title Fix thermostat types fix: thermostat types Oct 8, 2024
Copy link
Collaborator

@razor-x razor-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to block merge because this will be a breaking change / new major version, and I don't want this to merge early.

src/lib/seam/devices/use-devices.ts Outdated Show resolved Hide resolved
disableResourceIds,
disableConnectedAccountInformation,
disableClimateSettingSchedules,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should removed this from the API. Are there any other references to ClimateSettingSchedules in this project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Removed all in 3457ca4

@razor-x razor-x changed the title fix: thermostat types Remove Climate Setting Schedules Oct 18, 2024
@razor-x razor-x changed the base branch from main to beta October 21, 2024 22:45
@razor-x razor-x merged commit 41068ef into beta Oct 21, 2024
18 checks passed
@razor-x razor-x deleted the fix-thermostat-types branch October 21, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix compatibility with new thermostat types
3 participants