Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basename cannot contain .. prevents valid filenames from being sent, no sender-side warning #840

Open
zulc22 opened this issue Nov 13, 2024 · 1 comment

Comments

@zulc22
Copy link

zulc22 commented Nov 13, 2024

securing channel...basename cannot contain '..': 'Dragon Quest III - Soshite Densetsu e... (Japan).zip'

This error message prevented a transfer from occurring that took like five minutes to hash all the files, I understand it's probably a security thing to prevent files from going into unintended directories, but shouldn't the search string be '../', or '..\'? The sender side also had no warning for this and just spat EOF after the receiver connected. I think that both of these concerns could be addressed by checking the filenames with the same check on the server side, and that the substring should be changed.

@schollz
Copy link
Owner

schollz commented Nov 13, 2024

Feel free to make a pr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants