In 16.6.0 /home/git/gitlab/lib/gitlab/redis/wrapper.rb is broken

[Thomas-Ganter]

Title says it all.

/home/git/gitlab/lib/gitlab/redis/wrapper.rb is broken in the 16.6.0 docker image.
This was the result ...

2023-11-23 23:38:55,814 INFO spawned: 'mail_room' with pid 3164
2023-11-23 23:38:57,248 INFO success: mail_room entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-11-23 23:39:00,612 INFO exited: mail_room (exit status 1; not expected)
2023-11-23 23:39:01,603 INFO spawned: 'mail_room' with pid 3165
2023-11-23 23:39:02,605 INFO success: mail_room entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-11-23 23:39:05,565 INFO exited: mail_room (exit status 1; not expected)
2023-11-23 23:39:06,568 INFO spawned: 'mail_room' with pid 3166
2023-11-23 23:39:07,570 INFO success: mail_room entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-11-23 23:39:10,931 INFO exited: mail_room (exit status 1; not expected)
2023-11-23 23:39:11,935 INFO spawned: 'mail_room' with pid 3170
2023-11-23 23:39:12,937 INFO success: mail_room entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-11-23 23:39:15,795 INFO exited: mail_room (exit status 1; not expected)
2023-11-23 23:39:16,797 INFO spawned: 'mail_room' with pid 3180
2023-11-23 23:39:17,800 INFO success: mail_room entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-11-23 23:39:20,808 INFO exited: mail_room (exit status 1; not expected)
2023-11-23 23:39:21,811 INFO spawned: 'mail_room' with pid 3181
2023-11-23 23:39:22,814 INFO success: mail_room entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-11-23 23:39:25,763 INFO exited: mail_room (exit status 1; not expected)
2023-11-23 23:39:26,766 INFO spawned: 'mail_room' with pid 3182
2023-11-23 23:39:27,793 INFO success: mail_room entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-11-23 23:39:30,856 INFO exited: mail_room (exit status 1; not expected)
2023-11-23 23:39:31,859 INFO spawned: 'mail_room' with pid 3183
2023-11-23 23:39:32,861 INFO success: mail_room entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2023-11-23 23:39:35,909 INFO exited: mail_room (exit status 1; not expected)

and so on and so on.

Getting a fresh wrapper.rb from gitlab fixed it for me.
I used this version of the file and notice no issue so far.

[kkimurak]

Hi, thank you for your report.

This seems to be a bug of gitlab itself. This have been fixed by gitlab-org/gitlab!137279 (backported to 16.6.x by MR gitlab-org/gitlab!137296) but never released yet (at least I've checked just now).
As we use mostly same code of upstream release (except some patches and modifications applied during build), sameersbn/gitlab contains same issues that corresponding versions of upstreams (gitlab, gitaly, gitlab-shell, gitlab-pages and so on).

If you want a patched version of sameersbn/gitlab, please submit a pull request and request patched release (with tags like 16.6.0-1) to the maintainer. The maintainers are generally not active except when there is a release of gitlab, so there may be a delay in responding.
Also, don't forget to revert your changes once a fixed version (probably 16.6.1) is released.

[kkimurak]

gitlab v16.6.1 and later includes the MR gitlab-org/gitlab!137296. The merge commit is gitlab-org/gitlab@3ef9b98e.
This have been ported to gitlab-foss by commit gitlab-org/gitlab-foss@4f1a71c6. gitlab-foss v16.6.1 and later includes this commit.