-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecated .value
method
#123
Comments
Well, at least documentation should be updated first, to mention that this property is deprecated. |
Hello, err_value and ok_value is not covered in documentation, if I am not mistaken and they are not annotated by types, so deprecation looks premature |
The field is not being removed in the immediate future. The
|
Docs and migration guide have been updated in #159. Thanks for pointing out the issue with the docs. |
I'm thinking this will be removed when #180 is also done. Enough time will pass by then to remove this deprecated method. |
#121 deprecated the
.value
method. This method needs to be removed in a future version. Ideally we'd wait a while so users can have enough time to migrate away on their own.We could also perhaps change the deprecated method to start throwing an exception and returning
None
before we remove it completely.The text was updated successfully, but these errors were encountered: