-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tnum punctuation context sensitive #647
Comments
An additional remark: I am not sure what motivated this design choice. Is it because some people use the hyphen as a minus sign? If so, maybe you could implement the figure-wide hyphen as a contextual alternate that is activated only if it is sandwiched by two figures or preceded by a space and followed by a figure. |
I think #227 is the context behind the design decision. |
Thanks for the pointer! The issue is that
leading to the issue that I reported. Foreseeing this very type of “compromises in spacing,” @thomas-lowry stated
|
By the way, I realised that the spacing of Is this intended? |
This is indeed by design.
Indeed this is the reason; lots of people use hyphen instead of minus. You can even see this in places where you would expect proper typography, like online bank statements. Inter is designed to work well in "the real world" and sometimes compromises like this is needed. Same goes for lots of the technical aspects. For example, the variable font uses format 1 STAT records to be compatible with Microsoft Word, even though it means not supporting advanced style linking supported by other software. So I'd much rather have users apply What you're suggesting—with adding OT code to smartly insert tabular glyphs only where needed— is a good idea but is quite a bit of work, both implementation and QA. There are lots of glyphs that participate in |
First of all, a big thank you, @rsms, for creating—and continuously extending—this amazing typeface and making it available as an open-source font! I fully understand the compromises involved.
PS: I have seen |
Describe the bug
Activating tabular figures changes kerning/spacing of hyphen and other glyphs—such as quotation marks adjacent to periods or commas.
To Reproduce
Select tabular figures for (some part of) your text, including characters, punctuation, and hyphens—that is, not only for figures. More precisely, the hyphen becomes exactly as wide as the tabular figures. This can also be observed on https://rsms.me/inter/lab/?compare=system&feat-tnum=1&sample=Kerning%20misc.
Expected behavior
The spacing of the hyphen in-between words should not change. If anything, it should only change in-between numbers. Using contextual alternatives does not help: All it does is moving the hyphen upward in-between figures.
Screenshots
Environment
The text was updated successfully, but these errors were encountered: