Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/firebase realtime database #724

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

jfbenckhuijsen
Copy link
Contributor

@jfbenckhuijsen jfbenckhuijsen commented Dec 20, 2024

Fixes #133

@jfbenckhuijsen jfbenckhuijsen marked this pull request as ready for review January 3, 2025 14:20
@jfbenckhuijsen jfbenckhuijsen requested a review from a team as a code owner January 3, 2025 14:20
Copy link
Collaborator

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there real need for a Firebase Database extension? Isn't the existing Firestore extension already sufficient?

@jfbenckhuijsen
Copy link
Contributor Author

Is there real need for a Firebase Database extension? Isn't the existing Firestore extension already sufficient?

Well, depends on how you want to structure stuff. In principle, this could be part of the existing firebase extension (which also packs the auth stuff), it doesn't add any other transitive dependencies to that module. The module has another goal, which might validate the need for a separate module OTOH.

Lemme know what you prefer, either is fine with me

# Conflicts:
#	firebase-devservices/deployment/src/main/java/io/quarkiverse/googlecloudservices/firebase/deployment/testcontainers/FirebaseEmulatorContainer.java
@loicmathieu
Copy link
Collaborator

@jfbenckhuijsen my question was more of Firestore vs Firebase.
But I'm also a little concern about the cost to add a new extension if there already exist one with the same lib.

@jfbenckhuijsen
Copy link
Contributor Author

@jfbenckhuijsen my question was more of Firestore vs Firebase. But I'm also a little concern about the cost to add a new extension if there already exist one with the same lib.

Ah ok, clear. Firebase Realtime Database to my knowledge is a different product (with a different goal) than Firestore.

I can rewrite the extension to be part of the firebase-admin extension (this one has the same dependency). Downside is that the name would then not really fit the goal of that existing extension (we probably should rename it to -firebase instead of -firebase-admin, but that;s an backwards incompatible change ofc).

@loicmathieu
Copy link
Collaborator

OK, let's keep both.

By the way, I plan to do a release soon so it's been available in the next Quarkus release but there is a test related to your recent changes that fails in the Quarkiverse CI which test this extension with the main branch of Quarkus.

If you can have a look it would be great otherwise I'll have a look later.

See https://github.com/quarkiverse/quarkus-google-cloud-services/actions/runs/12823020927/job/35756877903

@jfbenckhuijsen
Copy link
Contributor Author

jfbenckhuijsen commented Jan 17, 2025

OK, let's keep both.

By the way, I plan to do a release soon so it's been available in the next Quarkus release but there is a test related to your recent changes that fails in the Quarkiverse CI which test this extension with the main branch of Quarkus.

If you can have a look it would be great otherwise I'll have a look later.

See https://github.com/quarkiverse/quarkus-google-cloud-services/actions/runs/12823020927/job/35756877903

@loicmathieu Looking at the error, I think (but logging is quite limited) that the issue is caused by the fact that we made some changes to the build CI script, which aren't reflected in the Quarkus snapshot build (i.e. the NPM stuff and the current user stuff). I can have a go at creating a PR for that, but would probably need some help there as I'm not really familiar with those scripts and tests.

--> #743

I assume we consider this as finished and ready for merge then? (Other review issues were resolved).

Copy link
Collaborator

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the doc to match the correct extension name, then we're good to merge 🎉

docs/modules/ROOT/pages/firebase-database.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/firebase-database.adoc Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be firebase-realtime-database.adoc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and also saw a copy/paste error in the devservices module Nav.adoc. Also fixed that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loicmathieu we should be good to go (once build finishes correctly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add support for firebase realtime database
2 participants