-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarkus Artemis dev services fail to start when running with Quarkus snapshot #665
Comments
@zhfeng the commit you mentioned is not yet released, right? So we cannot (yet) provide a fix? |
Yeah, exactly. But I think we can try it locally and the fix could be simple to just change |
OK, I test it locally. This fix works. diff --git a/core/deployment/src/main/java/io/quarkus/artemis/core/deployment/DevServicesArtemisProcessor.java b/core/deployment/src/main/java/io/quarkus/artemis/core/deployment/DevServicesArtemisProcessor.java
index 410b616..4f7dd05 100644
--- a/core/deployment/src/main/java/io/quarkus/artemis/core/deployment/DevServicesArtemisProcessor.java
+++ b/core/deployment/src/main/java/io/quarkus/artemis/core/deployment/DevServicesArtemisProcessor.java
@@ -130,7 +130,7 @@ public class DevServicesArtemisProcessor {
dockerStatusBuildItem,
configuration,
launchMode,
- devServicesConfig.timeout);
+ devServicesConfig.timeout());
if (service != null) {
devServices.put(name, service);
}
diff --git a/pom.xml b/pom.xml
index a82bd13..a00b014 100644
--- a/pom.xml
+++ b/pom.xml
@@ -39,7 +39,7 @@
<!-- Dependency versions -->
<artemis.version>2.38.0</artemis.version>
<camel-quarkus.platform.version>3.16.3</camel-quarkus.platform.version>
- <quarkus.version>3.16.3</quarkus.version>
+ <quarkus.version>999-SNAPSHOT</quarkus.version>
<quarkus-ironjacamar.version>1.5.0</quarkus-ironjacamar.version>
<!-- Project setup --> |
Great! Thanks @zhfeng ! |
It looks like quarkus has fixed in with quarkusio/quarkus@a5e8b1c |
@zhfeng I am not sure that we should close the issue. The "old" |
OK, let's reopen it. |
As far as I can see, this change will be released with quarkus |
Quarkus has reorganised some of the dev services config:
quarkusio/quarkus@bbb1009
It makes Quarkus Artemis dev services fail due to:
blocks
I'm not sure how to fix it in the current codebase. Or we have to fix it when the next Quarkus release?
The text was updated successfully, but these errors were encountered: