Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus Artemis dev services fail to start when running with Quarkus snapshot #665

Open
zhfeng opened this issue Nov 18, 2024 · 9 comments
Labels
blocked bug Something isn't working

Comments

@zhfeng
Copy link
Contributor

zhfeng commented Nov 18, 2024

Quarkus has reorganised some of the dev services config:

quarkusio/quarkus@bbb1009

It makes Quarkus Artemis dev services fail due to:

Caused by: java.lang.NoSuchFieldError: timeout
   at io.quarkus.artemis.core.deployment.DevServicesArtemisProcessor.start(DevServicesArtemisProcessor.java:128)

blocks

I'm not sure how to fix it in the current codebase. Or we have to fix it when the next Quarkus release?

@zhfeng zhfeng added bug Something isn't working blocked labels Nov 18, 2024
@zhfeng
Copy link
Contributor Author

zhfeng commented Nov 18, 2024

FYI @turing85 @gastaldi

@turing85
Copy link
Contributor

turing85 commented Nov 18, 2024

@zhfeng the commit you mentioned is not yet released, right? So we cannot (yet) provide a fix?

@zhfeng
Copy link
Contributor Author

zhfeng commented Nov 18, 2024

Yeah, exactly. But I think we can try it locally and the fix could be simple to just change devServicesConfig.timeout to devServicesConfig.timeout() ?

@zhfeng
Copy link
Contributor Author

zhfeng commented Nov 19, 2024

OK, I test it locally. This fix works.

diff --git a/core/deployment/src/main/java/io/quarkus/artemis/core/deployment/DevServicesArtemisProcessor.java b/core/deployment/src/main/java/io/quarkus/artemis/core/deployment/DevServicesArtemisProcessor.java
index 410b616..4f7dd05 100644
--- a/core/deployment/src/main/java/io/quarkus/artemis/core/deployment/DevServicesArtemisProcessor.java
+++ b/core/deployment/src/main/java/io/quarkus/artemis/core/deployment/DevServicesArtemisProcessor.java
@@ -130,7 +130,7 @@ public class DevServicesArtemisProcessor {
                             dockerStatusBuildItem,
                             configuration,
                             launchMode,
-                            devServicesConfig.timeout);
+                            devServicesConfig.timeout());
                     if (service != null) {
                         devServices.put(name, service);
                     }
diff --git a/pom.xml b/pom.xml
index a82bd13..a00b014 100644
--- a/pom.xml
+++ b/pom.xml
@@ -39,7 +39,7 @@
         <!-- Dependency versions -->
         <artemis.version>2.38.0</artemis.version>
         <camel-quarkus.platform.version>3.16.3</camel-quarkus.platform.version>
-        <quarkus.version>3.16.3</quarkus.version>
+        <quarkus.version>999-SNAPSHOT</quarkus.version>
         <quarkus-ironjacamar.version>1.5.0</quarkus-ironjacamar.version>
 
         <!-- Project setup -->

@turing85
Copy link
Contributor

Great! Thanks @zhfeng !

@zhfeng
Copy link
Contributor Author

zhfeng commented Dec 5, 2024

It looks like quarkus has fixed in with quarkusio/quarkus@a5e8b1c

@zhfeng zhfeng closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2024
@turing85
Copy link
Contributor

turing85 commented Dec 5, 2024

@zhfeng I am not sure that we should close the issue. The "old" GlobalDevServicesConfig is now deprecated and marked for removal (see quarkusio/quarkus@a5e8b1c#diff-d871539ea15a480fffb9731fcf1f1d5fc9959f333b178def1cb5bcdf0d8d2784R15), and we should switch to the new DevServicesConfig. WDYT?

@zhfeng
Copy link
Contributor Author

zhfeng commented Dec 6, 2024

OK, let's reopen it.

@zhfeng zhfeng reopened this Dec 6, 2024
@turing85
Copy link
Contributor

As far as I can see, this change will be released with quarkus 3.18.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants