Unsused argument in _PyCode_Quicken

[WolframAlph]

_PyCode_Quicken in specialize.c accepts PyObject *consts but does not use it. Not sure which type of issue to use, so creating blank one.

Linked PRs

• gh-128872: Remove unused consts argument #128873

[picnixz]

Instead of removing them, I think it's better to simply mark consts with a Py_UNUSED attribute (namely Py_UNUSED(consts)). The compiler could also optimize the call and the diff would be smaller. If we need to add it later for some reason, it's probably better that way.

However, just adding Py_UNUSED() is also not needed as the compiler could be already smart enough. Do we gain something with this change on macro and micro benchmarks?

[WolframAlph]

There is no difference in terms of generated machine code. As expected, compiler is smart enough to ignore it. But still, should it be left like this?

[picnixz]

If there is no difference, no need to change this. We rejected previous PRs that wanted to add Py_UNUSED() consistently. I don't think we want a successful build with -Wunused-parameter (otherwise there are many other places to change). It doesn't hurt to add it if _PyCode_Quicken() is changed, but otherwise, I'm not really convinced.

[WolframAlph]

Closing it then

[Eclips4]

_PyCode_Quicken is a purely internal API. So, I guess someone from the faster-cpython team should decide whether we should remove it or not. Maybe this parameter will be useful in the future.
cc @markshannon as author of the ddd9599 which removed the use of consts argument.

[brandtbucher]

If the arg is unused, let's remove it. The fact that it was left was just an oversight of that PR.

[WolframAlph]

Reopened PR.