-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut down multiple API requests from Geocoding.js #186
Comments
Ah, is this on local?
…On Wed, Feb 20, 2019 at 3:08 PM Pranshu Srivastava ***@***.***> wrote:
Currently there are two different functions sending requests to the Maps
API. We should look out for options to cut down this multiple use of the
API.
https://github.com/publiclab/leaflet-blurred-location/blob/51744030cd0847a0309cbbc3354482e35e17a2aa/src/core/Geocoding.js#L7
https://github.com/publiclab/leaflet-blurred-location/blob/51744030cd0847a0309cbbc3354482e35e17a2aa/src/core/Geocoding.js#L111
// Jasmine logs>> You have included the Google Maps JavaScript API multiple times on this page. This may cause unexpected errors. at>> https:/maps.googleapis.com/maps/api/js?libraries=places&language=en&key=AIzaSyDWgc7p4WWFsO3y0MTe50vF4l4NUPcPuwE:128 th>> You have included the Google Maps JavaScript API multiple times on this page. This may cause unexpected errors. at>> https:/maps.googleapis.com/maps/api/js?libraries=places&language=en&key=AIzaSyDWgc7p4WWFsO3y0MTe50vF4l4NUPcPuwE:128 th>> You have included the Google Maps JavaScript API multiple times on this page. This may cause unexpected errors. at>> https:/maps.googleapis.com/maps/api/js?libraries=places&language=en&key=AIzaSyDWgc7p4WWFsO3y0MTe50vF4l4NUPcPuwE:128 th>> You have included the Google Maps JavaScript API multiple times on this page. This may cause unexpected errors. at>> https:/maps.googleapis.com/maps/api/js?libraries=places&language=en&key=AIzaSyDWgc7p4WWFsO3y0MTe50vF4l4NUPcPuwE:128 th>> You have included the Google Maps JavaScript API multiple times on this page. This may cause unexpected errors. at>> https:/maps.googleapis.com/maps/api/js?libraries=places&language=en&key=AIzaSyDWgc7p4WWFsO3y0MTe50vF4l4NUPcPuwE:128 th
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#186>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ7muTRZSO2NQUMRqrI5B15KH-BRYks5vPdVmgaJpZM4bGTkj>
.
|
Yes, @jywarren, right after running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently there are two different functions sending requests to the Maps API. We should look out for options to cut down this multiple use of the API.
leaflet-blurred-location/src/core/Geocoding.js
Line 7 in 5174403
leaflet-blurred-location/src/core/Geocoding.js
Line 111 in 5174403
The text was updated successfully, but these errors were encountered: