Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concurrent submissions do not smartly iterate on id numbers #57

Open
mingness opened this issue Jan 13, 2025 · 3 comments
Open

concurrent submissions do not smartly iterate on id numbers #57

mingness opened this issue Jan 13, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@mingness
Copy link
Collaborator

mingness commented Jan 13, 2025

When there are two concurrent submissions, they will both be referenced to main, so will have the same id number. That means merges will have to be done one at a time, and after the first, the action for the subsequent submission should be rerun. Perhaps open issues with new-contribution should all rerun upon changes to main?

@mingness mingness added the bug Something isn't working label Jan 13, 2025
@mingness mingness changed the title concurrent submissions will not smartly iterate on id numbers concurrent submissions do not smartly iterate on id numbers Jan 13, 2025
@Stefterv
Copy link
Collaborator

Are the id's still used anywhere within the pipeline?

@mingness
Copy link
Collaborator Author

I think the id's are only used by the current contribution manager. They are not used by the contribution pipeline.

@Stefterv
Copy link
Collaborator

Only reference to id's that I could find where here:
https:///processing/processing4/app/src/processing/app/contrib/LocalContribution.java#L66-L68

I had a quick check locally and they are all set to null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants