-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling the same image filename in multiple folders #186
Comments
Many thanks for this @vdet! Now this is interesting. We haven't tested with plots this large in a little while! We don't have much guidance on the I'm curious as to the details of your images. All of the images should have been plotted in the scene. But some images may have been filtered out during the data prep stage. As you may know, when the user provides their list of images to be processed, we iterate through them and resize them into little images that have height If an image has 0 width after being resized (or the image has a height or width that's larger than the atlas size, which is 2048px by 2048px) it won't be retained in the atlases or the plot. I have a hunch that filter is what's causing the missing images. You can check the full list of images that were processed in The idea of using non-integer cell sizes is interesting! I'm actually not sure what would happen in that case. But I would probably use a cell size of 6 or 8 at a minimum... |
Just thinking a little more about this @vdet there are some other considerations that might be at play. If the number of images in the output image list is greater than the number of displayed images, it could be because of limitations in the GPU card of the host that's running the visualization. You can get some information on your system's GPU card here. If the atlases are too big, one can bump up against the Max Texture Image Units value. Or possibly we are packing more into a single draw call than your GPU can handle (there are a few GL parameters that influence the max draw call size). To alleviate concern over any of these lower-level issues, I'd start by counting the images in the generated image list (alternatively, you could check |
The images have all the same size: 224 x 224 px^2. I actually tried to set
The GPU is an AMD Radeon R9 M395 in a late 2015 27" retina iMac. All the best, |
Hello,
and All the best, |
@vdet many thanks for your note. Yes this is something we've thought about. The only challenge is that the filename serves as the foreign key that lets us create the connections between images and metadata rows. This means that if we process the full or relative image path when processing images, the user would have to include that path in their metadata, which could be quite challenging. What if we displayed a little warning indicating that there are duplicate filenames in the input dataset--would that be sufficient? I'm open to other ideas instead! |
Hi Douglas,
The user does provide a path already: to be able to use an image glob of the form Note that non-flat dir structures naturally occur in many contexts, when
Well I of course don't understand the inside out of your code, and can find an upstream fix for my application. Anyhow, a warning would sure help, I my case the effect was massive I could not miss it. In other cases some a few image will be missing while others will have the wrong metadata and land in the wrong spot in the geographic view (what helped my pinpoint the problem). Thanks, Vincent |
@vdet aha! Your note is very helpful. Right now, we process just the "basename" of each image and map that to the basename of the image specified in the metadata inputs (source). The motivation for using the file basenames was to allow users to create a static representation of their metadata that doesn't include relative or fully-qualified paths, as either of the latter would be cumbersome if one were to move the data. Perhaps we should check to see whether the |
Hi Douglas,
They can put all their dirs in one big dir if they need to move all images at once. This is actually what I did in my real life application with a root image dir containing sub dirs.
Not sure I understand what you mean. I'd suggest to leave the metadata All the best, Vincent |
I changed the title of this issue to better reflect the open task... |
Hi again,
I tried to display datasets up to ~600.000 images (pre-computed UMAP). Here is some feedback:
--cell_size
as a function of the number and size of input images?--cell_size
what set small enough the data where loaded by the server. But only a subset of the input images, possibly 1/2 of them, showed up in PixPlot. Is that expected? If it is, perhaps the images to be displayed could be selected at random.point_size
parameters).This being said I could already get insight from the subset of image I could view. Thanks!
Vincent
The text was updated successfully, but these errors were encountered: