Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Adding Twig Globals #46

Open
sghoweri opened this issue Nov 4, 2017 · 0 comments
Open

Support Adding Twig Globals #46

sghoweri opened this issue Nov 4, 2017 · 0 comments

Comments

@sghoweri
Copy link

sghoweri commented Nov 4, 2017

https://twig.symfony.com/doc/2.x/advanced.html#id1

I've actually already got a working POC patch for this that we've been using to share certain Design Token values across our Design System in a way that is Drupal / Grav friendly (vs only being available to PL):

https://github.com/bolt-design-system/bolt/blob/develop/.patches/addTwigGlobals.patch

https://github.com/bolt-design-system/bolt/blob/develop/packages/bolt-twig-extensions/globals/bolt-image-sizes.global.php

My question for @aleksip and @EvanLovely is about the way this extension gets called since I tried to do things in a more Symphony like way (in how this gets called). Thoughts?
sghoweri pushed a commit that referenced this issue Nov 4, 2017
@bolt-bot
feat: proof of concept implementation of adding Twig extension suppor…
af369e4 
…t for global variablesf, allowing for cross-platform interoperability. Addresses #46
@sghoweri sghoweri mentioned this issue Nov 4, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sghoweri