Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP] Optimise building cache #97

Open
itscaro opened this issue Oct 25, 2018 · 2 comments · May be fixed by #98
Open

[PHP] Optimise building cache #97

itscaro opened this issue Oct 25, 2018 · 2 comments · May be fixed by #98

Comments

@itscaro
Copy link
Contributor

itscaro commented Oct 25, 2018 •
edited
Loading

Expected Behaviour

When dependencies/requirements are not changed, these build steps should be cached.
Pros:

  • build time is reduced
  • reduce Github rate-limit issues (when not providing a Github token)
    Cons:
  • composer.json and php-extensions.sh must exist for this template, the user cannot delete them when they are not used

Current Behaviour

Any modification in function directory uncaches the build step starting from copy of function source codes.
@itscaro itscaro linked a pull request Oct 25, 2018 that will close this issue
Open
11 tasks
@itscaro
Copy link
Contributor Author

itscaro commented Oct 25, 2018

Derek add label: proposal

@itscaro
Copy link
Contributor Author

itscaro commented Oct 25, 2018

Derek add label: php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PHP] re-order dependency installations in order to optimise building caches itscaro/templates
1 participant
@itscaro