Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page feedback for Spring Boot Starter #5445

Open
robenie-cwt opened this issue Oct 21, 2024 · 4 comments
Open

Page feedback for Spring Boot Starter #5445

robenie-cwt opened this issue Oct 21, 2024 · 4 comments
Labels

Comments

@robenie-cwt
Copy link

Suggested improvements for page: https://opentelemetry.io/docs/zero-code/java/spring-boot-starter/out-of-the-box-instrumentation/

  1. I think the documentation does not state that the trace and span ids are not populated automatically when using the Spring Boot Starter. This was automatic when using the Java Agent and Micrometer Tracing so I was expecting that it was automatic as well for the Spring Boot Starter
  2. Not sure if this was also mentioned somewhere, but the logback-mdc-1.0 did not also say that the OpenTelemetryAppender should be the appender wrapping the AsyncAppender and not the otherway around.
@theletterf
Copy link
Member

@jeanbisutti WDYT?

@robenie-cwt
Copy link
Author

I reread my initial comment, and I guess I was not clear that what I'm referring to item 1 is the LogBack MDC not containing the trace id and span id. :)

@svrnm svrnm added the sig:java label Nov 4, 2024
@jeanbisutti
Copy link
Member

@robenie-cwt Thank you for you feedback!

About 1, the trace and span IDs will be automatically added by the OpenTelemetry starter to the Logbback MDC from the next release in November. I will update the opentelemetry.io documentation after the release.

About 2, do you want to create a PR in the opentelemetry-java-instrumentation repository?

@robenie-cwt
Copy link
Author

sure, I think I can create a PR for the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

4 participants