Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus exporter export instrumentation scope attributes #5846

Open
pellared opened this issue Sep 25, 2024 · 1 comment
Open

Prometheus exporter export instrumentation scope attributes #5846

pellared opened this issue Sep 25, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request pkg:exporter:prometheus Related to the Prometheus exporter package

Comments

@pellared
Copy link
Member

pellared commented Sep 25, 2024

Make Prometheus exporter to export instrumentation scope attributes

Prometheus exporter is REQUIRED to set the instrumentation scope attributes on the otel_scope_info metric: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk_exporters/prometheus.md and https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/prometheus_and_openmetrics.md#instrumentation-scope-1:

Scope attributes MUST also be added as labels following the rules described in the Metric Attributes section below.

We need to also solve this for Go:

CC @dashpole

@pellared pellared added enhancement New feature or request pkg:exporter:prometheus Related to the Prometheus exporter package blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made labels Sep 25, 2024
@dashpole dashpole self-assigned this Sep 25, 2024
@pellared pellared added this to the v1.32.0 milestone Oct 29, 2024
@pellared pellared assigned pellared and unassigned dashpole Oct 29, 2024
@pellared pellared removed the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Oct 30, 2024
@pellared
Copy link
Member Author

pellared commented Nov 7, 2024

PoC: #5947

@MrAlias MrAlias removed this from the v1.32.0 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pkg:exporter:prometheus Related to the Prometheus exporter package
Projects
None yet
Development

No branches or pull requests

3 participants