Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Make internal/sharedcomponent as a non-internal module #11622

Open
VihasMakwana opened this issue Nov 8, 2024 · 2 comments
Open

Proposal: Make internal/sharedcomponent as a non-internal module #11622

VihasMakwana opened this issue Nov 8, 2024 · 2 comments

Comments

@VihasMakwana
Copy link
Contributor

VihasMakwana commented Nov 8, 2024

We have two separate implementations of an internal/sharedcomponent module: one for the core and one for contrib. Both of the implementations have different APIs and different methods but they fundamentally do the same thing i.e use a map to track unique component per config.

I propose we move the contrib implementation to the core and expose it as a public API.

There couple of good arguments to make this a single, public API:

  • We no longer need to maintain two separate internal versions of the same functionality.
  • This allows other open-source collector distributions to take advantage of sharedcomonent.
  • simplified dependency. Now that go.opentelemetry.io/collector/internal/sharedcomponent is a separate module, it becomes easy for us to make it public and update contrib to use it.

@open-telemetry/collector-maintainers @open-telemetry/collector-contrib-maintainers let me know your thoughts on this!

@VihasMakwana
Copy link
Contributor Author

Related: #4266

@TylerHelmuth
Copy link
Member

We should not make this helper public until #10534 is sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants