Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove MetricsLevel from TelemetrySettings #11061

Open
codeboten opened this issue Sep 5, 2024 · 6 comments
Open

remove MetricsLevel from TelemetrySettings #11061

codeboten opened this issue Sep 5, 2024 · 6 comments

Comments

@codeboten
Copy link
Contributor

A discussion on 4-Sept-2024 lead to the agreement that the struct field MetricsLevel will be removed from TelemetrySettings. This field is there to allow component authors to check a level before deciding whether to incur the cost of calculating an expensive operation.

The alternative for component authors will be to check whether an instrument is enabled or not prior to calculating the metric. This is dependent on the PR in otel go to implement this and on the spec to stabilize this feature.

The decision was that if the change would take too long to implement upstream, then we would remove this field and move any component to configure their own metric level instead. This will allow the unblocking of the component module stabilization work.

@mx-psi
Copy link
Member

mx-psi commented Sep 9, 2024

@bogdandrutu Are you going to submit any changes to the spec related to this? (Maybe related to open-telemetry/opentelemetry-specification/issues/4200?)

@mx-psi
Copy link
Member

mx-psi commented Sep 13, 2024

Given that stabilization of Enabled is not on September's release (see open-telemetry/opentelemetry-specification/pull/4204), I think we should go with the alternative plan, since mid-October would delay us significantly

@mx-psi
Copy link
Member

mx-psi commented Nov 4, 2024

Summary of current state: open-telemetry/opentelemetry-specification/issues/4256 and open-telemetry/opentelemetry-specification/issues/4207 are blocking stabilization in the spec. There is a PR for 4256: open-telemetry/opentelemetry-specification/pull/4262 that is blocked by adding a prototype. Nobody is working on a prototype. For 4207, things seem to be moving forward.

This is one of the last issues blocking component 1.0. I have been focusing on #11499 and related issues in case it changes the roadmap and this becomes less important, but given the state above, we may want to go with the approach of "remove MetricsLevel and use feature gates for current use cases"/

@mx-psi
Copy link
Member

mx-psi commented Nov 14, 2024

There is also now an OTEP related to one of the issues above: open-telemetry/opentelemetry-specification/pull/4290

@mx-psi
Copy link
Member

mx-psi commented Nov 19, 2024

We discussed open-telemetry/opentelemetry-specification/issues/4256 at the 2024-11-19 spec meeting. We will close it on 2024-12-03 unless there are use case brought up based on open-telemetry/opentelemetry-specification#4256 (comment).

This also would mean that open-telemetry/opentelemetry-specification#4207 is not blocking stabilization, so we may (fingers crossed) be able to merge the stabilization PR.

@mx-psi
Copy link
Member

mx-psi commented Nov 25, 2024

This will be unblocked by open-telemetry/opentelemetry-go/issues/6002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants