Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure components in distributions match guidelines #588

Open
codeboten opened this issue Jul 3, 2024 · 5 comments
Open

ensure components in distributions match guidelines #588

codeboten opened this issue Jul 3, 2024 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@codeboten
Copy link
Contributor

There are several components in the contrib distribution that are still marked as development in the contrib repository. It would be great if there was a check that validated that components included in the distribution have a stability level of at least Alpha to match the expectation set by the distribution guideline

@codeboten codeboten added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 3, 2024
@codeboten
Copy link
Contributor Author

Here's the list of components as of 03-Jul-2024

Screenshot 2024-07-03 at 4 40 55 PM

@mowies
Copy link
Member

mowies commented Jul 10, 2024

What would you expect would be the consequence of the suggested check? Blocking the release? Just a warning? Creating an issue in the contrib repo?

@jpkrohling
Copy link
Member

jpkrohling commented Jul 10, 2024

For the components that are already part of a released version of contrib, they should be changed to be alpha (which is what @codeboten showed in the screenshot), as that's what they effectively are (at least). For new components, the PR shouldn't be merged until the component is at least alpha.

@codeboten
Copy link
Contributor Author

What would you expect would be the consequence of the suggested check? Blocking the release? Just a warning? Creating an issue in the contrib repo?

Ideally, a check could run on each PR to the manifests, to validate that the components match the guidelines. As a starting point, checking that all components are marked alpha for the contrib distro would have caught this issue

@mowies
Copy link
Member

mowies commented Jul 11, 2024

I guess it should be enough to check that the development key doesn't exist in the metadata.yml file for each component?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants