Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scoped-test failed on main after "Upgrade otel core (#37279)" #37287

Open
pjanotti opened this issue Jan 17, 2025 · 2 comments
Open

scoped-test failed on main after "Upgrade otel core (#37279)" #37287

pjanotti opened this issue Jan 17, 2025 · 2 comments
Assignees
Labels
ci-cd CI, CD, testing, build issues

Comments

@pjanotti
Copy link
Contributor

Component(s)

No response

Describe the issue you're reporting

The run for scoped-test failed on main after #37279 was merged

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12825992450/job/35765108783

Checking for affected tests...
/usr/bin/bash: -c: line 6: unexpected EOF while looking for matching `)'
make: *** [Makefile.Common:292: run-changed-tests] Error 2
Error: Process completed with exit code 1.
@pjanotti pjanotti added the ci-cd CI, CD, testing, build issues label Jan 17, 2025
@pjanotti pjanotti self-assigned this Jan 17, 2025
@pjanotti pjanotti changed the title scoped-test failed on main after "Upgrade otel core (#37279)"" scoped-test failed on main after "Upgrade otel core (#37279)" Jan 17, 2025
@pjanotti
Copy link
Contributor Author

pjanotti commented Jan 17, 2025

This is similar to the issue reported at https://cloud-native.slack.com/archives/C07CCCMRXBK/p1736476919222099. It seems that when the number of changed files is large enough it ends up generating a truncated bash script to be run. This may requires that the list of files to be passed as a file instead of a variable. 🤔

EDIT: ah, the way that it is right now it is expanding the variable at the bash statement, so it generates a very large single line bash expression.

@pjanotti
Copy link
Contributor Author

Besides the improvement above the GitHub action itself could check the number of affected components and above a certain threshold just add the Run Windows label and bail out since the concurrent execution leveraging the groups will likely be faster.

songy23 pushed a commit that referenced this issue Jan 18, 2025
…37298)

Doing in place expansion leads to hitting bash line size limits, this is
a cheap improvement that makes less likely to hit cases like #37287.

Tests on my fork
https://github.com/pjanotti/opentelemetry-service-contrib/actions/runs/12836050460/job/35796880868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues
Projects
None yet
Development

No branches or pull requests

1 participant