Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/splunkenterprise] Add Attributes to track Build & Version Data #36330

Open
michael-burt opened this issue Nov 12, 2024 · 4 comments
Open
Labels

Comments

@michael-burt
Copy link
Contributor

Component(s)

No response

Is your feature request related to a problem? Please describe.

I would like to attach splunkd_build and splunkd_version attributes to metrics being emitted by the Splunk Enterprise Receiver. I am unsure whether these should be added as "Resource Attributes" or just normal "Attributes". These peices of metadata about the Splunk host are available on the /services/server/info API endpoint.

Describe the solution you'd like

I think these pieces of data should be added as either attributes or resource attributes.

Describe alternatives you've considered

I have implemented a new collector to emit this data as a metric, see here: #36118

Upon reflection, this does not seem like the correct approach. This data is useful when processing all metrics emitted by this receiver, not just the info metric.

Additional context

No response

@michael-burt michael-burt added enhancement New feature or request needs triage New item requiring triage labels Nov 12, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme removed the needs triage New item requiring triage label Nov 12, 2024
@shalper2
Copy link
Contributor

I think this will be a good enhancement. A couple notes: I think to begin with we will want to have this set to off by default. This way existing users who don't care about these attributes don't suddenly get flooded with a bunch more data. Second, I don't think it would make sense to have these attributes be updated every time the scrape function is called, however we do have to imagine that version and build info could change during the lifetime of the collector instance so we must update it occasionally. I propose we scrape this information on a hardcoded, relatively lengthy interval. Perhaps every 60m? Thoughts on this? Any other considerations?

@michael-burt
Copy link
Contributor Author

For my use case, 60m may be too long to wait. Could this be a configurable setting perhaps? I don't think it would put too much load on Splunk to fetch this data on every scrape by the receiver, either.

@shalper2
Copy link
Contributor

I think that is definitely possible. Good to know re: load on Splunk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants