Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fix all jsx-a11y plugin warnings #4139

Open
7 of 14 tasks
nickytonline opened this issue Sep 26, 2024 · 10 comments
Open
7 of 14 tasks

Bug: Fix all jsx-a11y plugin warnings #4139

nickytonline opened this issue Sep 26, 2024 · 10 comments
Assignees

Comments

@nickytonline
Copy link
Member

nickytonline commented Sep 26, 2024

This is an overarching issue to oversee all the fixes that the jsx-a11y eslint plugin has surfaced.

Note when fixing an issue, for example an onClick on a div, use a native button element instead of adding all the event handlers and aria-* attributes to fix the issue. Native elements like a button handle focus events, etc.

Please tackle one issue at a time so others can contribute as well.

Tasks:

Once all these issues are fixed, the last thing to do is to set the jsx-a11y plugin to error instead of warn. See #4110

@nickytonline nickytonline self-assigned this Sep 26, 2024
Copy link
Contributor

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

@nickytonline
Copy link
Member Author

I've self-assigned this to just track the overarching issue.

@nickytonline
Copy link
Member Author

@FatumaA, if you want to drive this whole effort, let me know, and I can assign this overarching issue to you.

@FatumaA
Copy link
Contributor

FatumaA commented Sep 26, 2024

I would love to do that!

@nickytonline nickytonline assigned FatumaA and unassigned nickytonline Sep 26, 2024
@shubhamchasing
Copy link
Contributor

@nickytonline Can I contribute to some of this issues

@nickytonline
Copy link
Member Author

@FatumaA is driving this effort, but go for it.

Please tackle one issue at a time so others can contribute as well.

@michaella23
Copy link

@FatumaA I would love to help with these. Let me know where I can jump in. 🙂

@FatumaA
Copy link
Contributor

FatumaA commented Sep 29, 2024

Hi Michaella,
Thank you for that! 😊

Please take a look at any of the linked issues above that don't have the triage label and that are not assigned to anyone else.

You can claim any such issues by commenting ".take" on it.

Please take one issue at a time

Copy link
Contributor

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor.

1 similar comment
Copy link
Contributor

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants