Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could our github-bot create PR to homebrew-core ? #233

Open
ZYSzys opened this issue May 6, 2019 · 1 comment
Open

Could our github-bot create PR to homebrew-core ? #233

ZYSzys opened this issue May 6, 2019 · 1 comment

Comments

@ZYSzys
Copy link
Member

ZYSzys commented May 6, 2019

I found our github-bot create PRs to docker-library/official-images, so wondering could he also create PRs to homebrew-core ?

Then maybe we can access the latest Node.js from homebrew more quickly.

Screen Shot 2019-05-06 at 10 16 23 PM

@phillipj
Copy link
Member

phillipj commented May 7, 2019

That trick is kind of an illusion so to speak, as it's actually Travis CI who does everything in the docker-node example you showed above. The only thing related to the github-bot, is an GitHub API token which allows Travis CI to open PRs from the github-bot account -- does that make sense?

For clarity, I'm surely not negative to the idea your proposing, I just wanted to shed some light on how the docker-node example actually works.

Refs nodejs/docker-node#672
Refs nodejs/docker-node#670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants