Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against latest stable and unstable regularly #853

Open
iFreilicht opened this issue Oct 28, 2024 · 2 comments
Open

Test against latest stable and unstable regularly #853

iFreilicht opened this issue Oct 28, 2024 · 2 comments
Labels
testing Missing or incorrect tests

Comments

@iFreilicht
Copy link
Contributor

iFreilicht commented Oct 28, 2024

#850 was caused by us not testing whether PRs (or even master) is compatible with the latest stable release of nixpkgs.

AFAIU, we're basically already testing whether disko is compatible with current latest unstable via the github action (which actually is failing right now 😬), but maybe there's a better way?

@iFreilicht iFreilicht added the testing Missing or incorrect tests label Oct 28, 2024
@Mic92
Copy link
Member

Mic92 commented Nov 8, 2024

I think having an automatic flake update is already the best way. You don't want to break people's pull request because for some unrelated regressions caused in a different place.
It's up to us to fix flake update pull request.

@iFreilicht
Copy link
Contributor Author

Okay that works for unstable, but what about the latest stable release? This is currently not covered in any way, is it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Missing or incorrect tests
Projects
None yet
Development

No branches or pull requests

2 participants