Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status Weighting Rules #439

Open
aso1124 opened this issue Oct 16, 2024 · 1 comment
Open

Status Weighting Rules #439

aso1124 opened this issue Oct 16, 2024 · 1 comment
Assignees

Comments

@aso1124
Copy link
Contributor

aso1124 commented Oct 16, 2024

Allow customization of how a signal status affects the overall status for the step it belongs to.

Each step can have a set of weighting rules defined for it. The user will be able to configure signals as either contributing to the status calculation, or exclude them entirely

  1. Worst case wins (default): the step status is the same as the worst status for any of its signals (i.e. one signal is red, the step is red)
  2. Percentage evaluation: the step status is set if a certain percentage of signals in the step are in warning/critical. There should be gradations ... e.g. if 25% of signals are red, then the step goes yellow; if 50% of signals are red, the step goes red.
    In the percentage scenario, we also need to allow the user to set Critical Signals that will override the percentage calculations - if Critical Signals are set, they basically take precedence and set the Step status based on their state. This is a bit complex and needs a little more thought .. for instance, what if the percentage rule would set the step to red, but there's a Critical Signal that is only in yellow? Does the step go yellow or red?
@aso1124 aso1124 changed the title Edit Flow: Rule Weightings Status Weighting Rules Oct 16, 2024
@khpeet khpeet self-assigned this Oct 18, 2024
@khpeet
Copy link
Contributor

khpeet commented Oct 18, 2024

Some initial thoughts/opinions:

  • Any signal marked as critical should override any percentage based config. (i.e - If I set 50% threshold, and only 25% of signals are red, BUT there is a critical marked signal in that 25%, the step should still be fully critical/warning state).
  • Should we do static gradations, or just simply allow the user to choose a percentage value between 0-100 for any given step? (via textbox) - That may be simpler, and is easily calculated (and mimics how this is done in Workloads)
  • If no step percentage is configured AND no signals under that step are marked as critical (to override any status), then the default is how the step status is implemented today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants