Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from GTK 3 to GTK 4 #104

Open
vanillajonathan opened this issue Jul 13, 2022 · 4 comments
Open

Migrate from GTK 3 to GTK 4 #104

vanillajonathan opened this issue Jul 13, 2022 · 4 comments

Comments

@vanillajonathan
Copy link
Contributor

vanillajonathan commented Jul 13, 2022

Here is the GTK migration guide:
https://docs.gtk.org/gtk4/migrating-3to4.html

Commit ac2c123 was the first step!

@mvo5
Copy link
Owner

mvo5 commented Jul 14, 2022

Hey, yeah, I added ac2c123 for this. I would love to port it eventually but help would be welcome.

@albert-tomanek
Copy link

@mvo5 I can help with this. Can you think of any parts of the code right now that are incompatible with Gtk4?

@mvo5
Copy link
Owner

mvo5 commented Nov 27, 2024

@albert-tomanek Thanks, help would be much appreciated. I don't know if there is anything incompatible in the code, it is now build with -DGDK_DISABLE_DEPRECATED and -DGTK_DISABLE_DEPRECATED and that works. Historically the gtk/rgpkgtreeview.cc has seen tricky because it is a custom listview/treeview (for performance reasons). Most of the other pieces are relatively standard gtk. But keep in mind this went all the way from gtk1->gtk2->gtk3 so the code has a lot of history (and unfortunately it shows in some areas!). But I hope this does not scare you away, I would love to get help and start a gtk4 branch!

@vanillajonathan
Copy link
Contributor Author

@albert-tomanek You're giving it a go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants