Widget: heat map

[fgksgf]

Hello, I implemented a heat map widget with termdash in SkyWalking-CLI, like this:

I want to contribute it back recently, but I need some time to polish code to make it more general. I think the format of input data should be [['xlabel', 'ylabel', value],...], how about you ?

If you have any advice about the widget, please let me know :)

[mum4k]

Hi @fgksgf, that heat map widget looks great! If you are willing to contribute it, this would certainly be a good addition to termdash.

I will be more than happy to help you with design of the API and code cleanup. It is hard for me to answer questions or provide a suggestions without more context though. My suggestion would be to start by sending a PR with the API only. That is just the function definitions and their comments without any implementations. That would help me to understand the proposed structure and would allow us to discuss the widget's design. Here is an example of what I mean by sending just function's definition and comment without implementation:

// Values sets the values to be displayed by the BarChart.
// Each value ends up in its own bar. The values must not be negative and must
// be less or equal the maximum value. A bar displaying the maximum value is a
// full bar, taking all available vertical space.
// Provided options override values set when New() was called.
func (bc *BarChart) Values(values []int, max int, opts ...Option) error {
    return errors.New("not implemented")
}

We could do this for all the functions and options that widget will have and then follow up with a second PR that will contain the implementation. Does this work for you?

[fgksgf]

No problem, I will do this.
Thanks for your reply.

[mum4k]

Great, thank you for your help!