You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Over in #700 I tried upgrading our docker images to Ubuntu 24.04, which includes Python 3.12. One of the issues I encountered was that cyhunspell fails to compile with errors such as:
[task 2025-01-10T17:32:25.823Z] hunspell/hunspell.cpp: In function ‘Py_ssize_t __Pyx_PyIndex_AsSsize_t(PyObject*)’:
[task 2025-01-10T17:32:25.823Z] hunspell/hunspell.cpp:16201:47: error: ‘PyLongObject’ {aka ‘struct _longobject’} has no member named ‘ob_digit’
[task 2025-01-10T17:32:25.823Z] 16201 | const digit* digits = ((PyLongObject*)b)->ob_digit;
[task 2025-01-10T17:32:25.823Z] | ^~~~~~~~
This is due to ob_digit disappearing after Python 3.10.
There doesn't seem to be an obvious drop in replacement for this. One commenter suggests using spylls, a pure python version of hunspell. https://github.com/cdhigh/chunspell may have fixed the issue, although it specifically says it has removed caching and batch functionality, which may or may not matter to us. We could also consider forking of course, and applying the same fix that kenlm did, which may have little downside considering how unmaintained this ecosystem is.
This is not a highly urgent issue, but eventually we'll need to get off of Python 3.10 when it and/or Ubuntu 22.04 are no longer supported.
The text was updated successfully, but these errors were encountered:
Seems that chunspell is slower. Can you check if this one compiles on your environmnent? pip install git+https://github.com/MartinHlavna/cython_hunspell/. It is the one in the PR 38.
Over in #700 I tried upgrading our docker images to Ubuntu 24.04, which includes Python 3.12. One of the issues I encountered was that cyhunspell fails to compile with errors such as:
This is due to
ob_digit
disappearing after Python 3.10.kenlm had similar issues, which they fixed upstream. The hunspell we're using has not been updated in 3 years, and does not have a similar fix.
There doesn't seem to be an obvious drop in replacement for this. One commenter suggests using spylls, a pure python version of hunspell. https://github.com/cdhigh/chunspell may have fixed the issue, although it specifically says it has removed caching and batch functionality, which may or may not matter to us. We could also consider forking of course, and applying the same fix that kenlm did, which may have little downside considering how unmaintained this ecosystem is.
This is not a highly urgent issue, but eventually we'll need to get off of Python 3.10 when it and/or Ubuntu 22.04 are no longer supported.
The text was updated successfully, but these errors were encountered: